Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCHEMA: Convert datatype lists to objects #1074

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

effigies
Copy link
Collaborator

This allows us to have an unambiguous name for each rule, such as schema.rules.datatypes.anat.nonparametric.

@effigies effigies requested a review from tsalo as a code owner April 14, 2022 19:28
@tsalo
Copy link
Member

tsalo commented Apr 14, 2022

I think the changes you need to make to make_entity_table and make_filename_template are pretty small. Both functions just loop through the list, so you just need loop through the dict instead.

@bids-standard bids-standard deleted a comment from tsalo Apr 14, 2022
@bids-standard bids-standard deleted a comment from tsalo Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.50%. Comparing base (acb2d92) to head (24c0aa4).

Additional details and impacted files
@@              Coverage Diff               @@
##           schema-sprint    #1074   +/-   ##
==============================================
  Coverage          71.50%   71.50%           
==============================================
  Files                  9        9           
  Lines                930      930           
==============================================
  Hits                 665      665           
  Misses               265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 5fcde7b into bids-standard:schema-sprint Apr 14, 2022
@effigies effigies deleted the name-tables branch April 14, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants