Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Fix internal links implicitly #1096

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Apr 27, 2022

To avoid some boilerplate, I wanted to see if we could get away with fixing linking without modifying the macro calls at all, from the spec side.

Patch on top of #1056. Might just be a bad idea, but I want to see if it builds.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @effigies I like this solution. Looks like black magic to me, but why not 😏

tools/schemacode/schemacode/render.py Show resolved Hide resolved
tools/mkdocs_macros_bids/macros.py Outdated Show resolved Hide resolved
tools/schemacode/schemacode/render.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1096 (e31d255) into master (7e16903) will increase coverage by 1.18%.
The diff coverage is 100.00%.

❗ Current head e31d255 differs from pull request most recent head 5e07fe3. Consider uploading reports for the commit 5e07fe3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1096      +/-   ##
==========================================
+ Coverage   70.53%   71.71%   +1.18%     
==========================================
  Files           9        9              
  Lines         930      937       +7     
==========================================
+ Hits          656      672      +16     
+ Misses        274      265       -9     
Impacted Files Coverage Δ
tools/schemacode/schemacode/render.py 96.04% <100.00%> (+0.10%) ⬆️
tools/schemacode/schemacode/_version.py 38.90% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111034d...5e07fe3. Read the comment docs.

sappelhoff and others added 5 commits April 27, 2022 15:51
add test

try new method

REPLACEME -> PATH_TO_SRC

remove first attempt

add relpaths make_columns_table

use PATH_TO_SRC in columns.yaml

html -> md

add relpath arg for glossary

fix tests

add relpath for suffix tables

add relpath for metadata

add tests

run black

PATH_TO_SRC -> SPEC_ROOT

fix param ordering consistency

'..'|'.' -> page.file

relpath -> page_file

detect relpath from page.file

fix docstrings

fix tests

run black

fix PDF build

MNT: Restore sources

Revert test_render changes
@effigies
Copy link
Collaborator Author

effigies commented Apr 27, 2022

@sappelhoff I squashed all your changes and my reversions of some changes into a single commit so that it would be easy to rebase and limit the amount of history devoted to experimentation. Let me know if you prefer to keep your history.

@sappelhoff sappelhoff marked this pull request as ready for review April 28, 2022 07:31
@sappelhoff sappelhoff requested a review from tsalo as a code owner April 28, 2022 07:31
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot @effigies.

@sappelhoff sappelhoff merged commit a4a03dd into bids-standard:master Apr 29, 2022
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
2 participants