-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Create macro to render fields within objects #1097
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
+ Coverage 70.75% 71.11% +0.35%
==========================================
Files 9 9
Lines 937 952 +15
==========================================
+ Hits 663 677 +14
- Misses 274 275 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, +1 to merge after a rebase and observing the "review time"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be REALLY nice to have in. Thanks @tsalo
If no one raises an issue with this one I'll merge it tomorrow. |
Closes #841.
Basically, we can move sub-object definitions into the actual object definitions now that we have a function to render sub-objects directly.
Here's what the new Genetics metadata sub-object table looks like:
I can adopt any kind of notation for the key name column. Maybe
Genetics[Dataset]
?[Genetics]Dataset
?