Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] Create macro to render fields within objects #1097

Merged
merged 7 commits into from
May 4, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 28, 2022

Closes #841.

Basically, we can move sub-object definitions into the actual object definitions now that we have a function to render sub-objects directly.

Here's what the new Genetics metadata sub-object table looks like:

image

I can adopt any kind of notation for the key name column. Maybe Genetics[Dataset]? [Genetics]Dataset?

@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1097 (2296d0b) into master (a4a03dd) will increase coverage by 0.35%.
The diff coverage is 68.57%.

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   70.75%   71.11%   +0.35%     
==========================================
  Files           9        9              
  Lines         937      952      +15     
==========================================
+ Hits          663      677      +14     
- Misses        274      275       +1     
Impacted Files Coverage Δ
tools/schemacode/schemacode/render.py 92.83% <68.57%> (-3.22%) ⬇️
tools/schemacode/schemacode/_version.py 38.90% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a146fa...2296d0b. Read the comment docs.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, +1 to merge after a rebase and observing the "review time"

@tsalo tsalo requested review from effigies and Remi-Gau April 29, 2022 13:24
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be REALLY nice to have in. Thanks @tsalo

@tsalo tsalo added the schema-code Updates or changes to the code used to parse, filter, and render the schema. label Apr 29, 2022
@tsalo
Copy link
Member Author

tsalo commented May 3, 2022

If no one raises an issue with this one I'll merge it tomorrow.

@tsalo tsalo merged commit 9842cea into bids-standard:master May 4, 2022
@tsalo tsalo deleted the subobject-tables branch May 4, 2022 14:32
@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release. schema-code Updates or changes to the code used to parse, filter, and render the schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify usage of "dot notation" for sub-objects
4 participants