-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add filename template legend #1219
Closed
Closed
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f49ca5e
install tools as editable via requirements
Remi-Gau d57614e
update doc
Remi-Gau 453fef6
add legend
Remi-Gau c283e2c
update CI
Remi-Gau b76547b
add black to pre-commit and apply
Remi-Gau a33f3da
add flake8 to precommit
Remi-Gau 866e248
lint
Remi-Gau b7adfcb
Merge branch 'master' into add_legend
effigies 6e28924
Update tools/schemacode/bidsschematools/render.py
Remi-Gau 718e2b3
Merge branch 'master' into add_legend
effigies bf6ad1f
Update tools/schemacode/bidsschematools/render.py
Remi-Gau d77e072
Merge branch 'master' into add_legend
Remi-Gau f519b30
update legend
Remi-Gau 281227d
use pdf format
Remi-Gau 9328b7c
lint
Remi-Gau a60078f
remove indent
Remi-Gau 446de51
remove indent
Remi-Gau 1ab1836
fix pdf build
Remi-Gau 91ed8ef
lint
Remi-Gau 0af8ce6
try fixing html rendering
Remi-Gau 2397466
remove extra punctuation
Remi-Gau 6b7d7f9
lint
Remi-Gau 8f086b8
use markdown render
Remi-Gau 7169abf
add python import sort to pre commit and apply to non-schema code
Remi-Gau f7625cd
lint
Remi-Gau 86a7c30
Merge branch 'master' into add_legend
Remi-Gau 06ff974
Update tools/schemacode/bidsschematools/render.py
Remi-Gau a70c060
Update .pre-commit-config.yaml
Remi-Gau 25574bd
Update tools/schemacode/bidsschematools/render.py
Remi-Gau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
ignore: | ||
- "*/*/tests/*" | ||
- "**/tests/*" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,30 @@ | ||
# See https://pre-commit.com for more information | ||
# See https://pre-commit.com/hooks.html for more hooks | ||
exclude: 'tools/schemacode/bidsschematools/tests/data/broken_dataset_description.json' | ||
repos: | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.0.1 | ||
hooks: | ||
- id: trailing-whitespace | ||
- id: end-of-file-fixer | ||
- id: check-yaml | ||
- id: check-json | ||
- id: check-ast | ||
- id: check-added-large-files | ||
- id: check-case-conflict | ||
|
||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.3.0 | ||
hooks: | ||
- id: trailing-whitespace | ||
- id: end-of-file-fixer | ||
- id: check-yaml | ||
- id: check-json | ||
- id: check-ast | ||
- id: check-added-large-files | ||
- id: check-case-conflict | ||
|
||
- repo: https://github.com/psf/black | ||
rev: 22.6.0 | ||
hooks: | ||
- id: black | ||
|
||
- repo: https://github.com/pycqa/flake8 | ||
rev: '5.0.4' | ||
hooks: | ||
- id: flake8 | ||
|
||
- repo: https://github.com/asottile/reorder_python_imports | ||
rev: "v3.8.2" | ||
hooks: | ||
- id: reorder-python-imports | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -302,7 +302,6 @@ is to use the `requirements.txt` file contained in this repository as follows: | |
```bash | ||
pip install -U pip | ||
pip install -r requirements.txt | ||
pip install -e tools/schemacode/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So this should be restored. |
||
``` | ||
|
||
The first command ensures you are using an up to date version of `pip`, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
"""Inspect the pandoc log for warnings that should be raised as errors.""" | ||
|
||
# %% | ||
import json | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you prefer this over the more standard
isort
?