Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ENH] Link to filename element definitions in filename templates" #1247

Closed
wants to merge 1 commit into from

Conversation

effigies
Copy link
Collaborator

Reverts #1228

Going to need to resolve the SPEC_ROOT stuff to make this work.

@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1247 (fcb3c2d) into master (ea25a5f) will decrease coverage by 0.14%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #1247      +/-   ##
==========================================
- Coverage   88.23%   88.09%   -0.15%     
==========================================
  Files           6        6              
  Lines        1020      974      -46     
==========================================
- Hits          900      858      -42     
+ Misses        120      116       -4     
Impacted Files Coverage Δ
tools/schemacode/bidsschematools/render.py 93.13% <92.30%> (-0.05%) ⬇️
tools/schemacode/bidsschematools/utils.py 80.00% <100.00%> (-0.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@effigies effigies closed this Aug 23, 2022
@effigies effigies deleted the revert-1228-link-in-templates branch August 23, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant