-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Remove redundant entity definitions on MRI page #1265
[ENH] Remove redundant entity definitions on MRI page #1265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
+ Coverage 87.95% 88.18% +0.22%
==========================================
Files 6 6
Lines 1038 1041 +3
==========================================
+ Hits 913 918 +5
+ Misses 125 123 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for this refactoring @tsalo
Had a quick look I think that there may be a paragraph or 2 we could similarly remove from PET or microscopy in another PR.
Absolutely! I definitely want to work through the rest of the spec to remove anything unnecessary. |
Related to #612.
This PR removes any paragraphs describing entities, wherein the description does not differ appreciably from, or expand upon, the official entity definition in the schema, from the MRI page.