Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Drop the functional and f for NIRS #1325

Merged
merged 5 commits into from
Oct 17, 2022

Conversation

rob-luke
Copy link
Member

@rob-luke rob-luke commented Oct 16, 2022

This PR removes the wording functional near-infrared spectroscopy (fNIRS) in favor of near-infrared spectroscopy (NIRS) as discussed in #802 (comment)

See also the associated change in the examples repo:

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 88.33% // Head: 88.33% // No change to project coverage 👍

Coverage data is based on head (3171d9c) compared to base (144b61a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1325   +/-   ##
=======================================
  Coverage   88.33%   88.33%           
=======================================
  Files          11       11           
  Lines        1080     1080           
=======================================
  Hits          954      954           
  Misses        126      126           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rob-luke
Copy link
Member Author

@bids-maintenance could you please review

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rob-luke!

please note that @bids-maintenance is a bot 🙂 the real tag for the maintainers is @bids-standard/maintainers.

I pushed some commits, please double check that these are all fine with you.

If yes, we can merge and then plan the release!

@sappelhoff sappelhoff added this to the 1.8.0 milestone Oct 17, 2022
@rob-luke
Copy link
Member Author

Thanks @sappelhoff this looks great. Thanks for catching the items I missed. LGTM 🚀

@sappelhoff sappelhoff merged commit 296ec42 into bids-standard:master Oct 17, 2022
@rob-luke rob-luke deleted the NIRS branch October 17, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants