-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Drop the functional and f for NIRS #1325
Conversation
Codecov ReportBase: 88.33% // Head: 88.33% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1325 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 11 11
Lines 1080 1080
=======================================
Hits 954 954
Misses 126 126 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@bids-maintenance could you please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rob-luke!
please note that @bids-maintenance is a bot 🙂 the real tag for the maintainers is @bids-standard/maintainers
.
I pushed some commits, please double check that these are all fine with you.
If yes, we can merge and then plan the release!
Thanks @sappelhoff this looks great. Thanks for catching the items I missed. LGTM 🚀 |
This PR removes the wording
functional near-infrared spectroscopy (fNIRS)
in favor ofnear-infrared spectroscopy (NIRS)
as discussed in #802 (comment)See also the associated change in the examples repo: