Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add qMRI fieldmap filename templates #1336

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[ENH] Add qMRI fieldmap filename templates #1336

merged 1 commit into from
Nov 3, 2022

Conversation

Remi-Gau
Copy link
Collaborator

closes #1335

agahkarakuzu
agahkarakuzu approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@agahkarakuzu agahkarakuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro lists all fmap related suffixes for both maps and file collections, looks good to me. Thank you!

tsalo
tsalo approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@effigies effigies changed the title [ENH] add macro qmri fmap [ENH] Add qMRI fieldmap filename templates Nov 3, 2022
@effigies effigies merged commit 57b9901 into bids-standard:master Nov 3, 2022
@Remi-Gau Remi-Gau deleted the qmri_fmap branch December 6, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@tsalo tsalo tsalo approved these changes

@agahkarakuzu agahkarakuzu agahkarakuzu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No filename template for qMRI fieldmaps
4 participants
@Remi-Gau @effigies @tsalo @agahkarakuzu