Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] add missing processing entity for MEG physio files and render physio filename templates for fNIRS #1355

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

Remi-Gau
Copy link
Collaborator

fixes #1354

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 88.65% // Head: 88.65% // No change to project coverage 👍

Coverage data is based on head (3472eea) compared to base (e70278c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1355   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          11       11           
  Lines        1084     1084           
=======================================
  Hits          961      961           
  Misses        123      123           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -29,7 +29,6 @@ timeseries:
- beh
- eeg
- ieeg
- meg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is meg being removed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is handled separately below to allow for the proc extension.

@effigies
Copy link
Collaborator

Isn't proc like rec, where it's the same scan but processed differently? What does it mean for that to apply to physio or stim data?

@Remi-Gau
Copy link
Collaborator Author

Isn't proc like rec, where it's the same scan but processed differently? What does it mean for that to apply to physio or stim data?

I think we had discussed this extensively here: #894

@effigies
Copy link
Collaborator

Okay. If it's been discussed I won't reopen it.

Copy link
Member

@rob-luke rob-luke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sappelhoff sappelhoff merged commit 8c8dd94 into bids-standard:master Nov 16, 2022
@Remi-Gau Remi-Gau deleted the physio_meg branch December 6, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] physio is handled differently for MEG between 1.7 and latest
4 participants