[MISC] Update site_name and release protocol #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@franklin-feingold is this ready for review? Perhaps some other people aside from the two of us should have a look at it? |
|
Yup! This is ready for review. Yeah, I think once Chris reviews and see his thoughts, that could be sufficient |
chrisgorgo
approved these changes
Feb 7, 2019
franklin-feingold
added a commit
that referenced
this pull request
Feb 7, 2019
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #134
This will have the readthedocs specification indicate what version it is at. This is adding to our release protocol. For latest we will be in vX.X.X-dev and when we are ready for a release (stable) the mkdocs.yml site_name will change to reflect the new version. Then after the github release, submit a PR to bring the site_name back to dev, because stable will have captured the new version, but we will be back in dev at that moment.