[ENH] clarify encoding of README, CHANGES, TSV, and JSON files #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this driven by a particular issue or need? |
chrisgorgo
approved these changes
Feb 7, 2019
franklin-feingold
approved these changes
Feb 7, 2019
It came up as a technical question from the audience during a talk that @robertoostenveld and I held last week. |
sappelhoff
changed the title
|
Thanks! |
franklin-feingold
added a commit
that referenced
this pull request
Feb 7, 2019
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was no indication about which encoding should be used for TSV files. It was probably meant to mention UTF-8, so I added this.