Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Use "Tag XXXX, YYYY" not "Tag (XXXX,YYYY)" for DICOM Tags #1758

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

yarikoptic
Copy link
Collaborator

In general I like more (XXXX,YYYY) form but the other form more prevalent and thus what I also suggested in https://github.com/bids-standard/bids-specification/pull/1450/files

Attention to this was triggered by @CPernet 's comment in

src/schema/objects/metadata.yaml and src/schema/rules/checks/asl.yaml src/schema/rules/sidecars/mri.yaml all use form without () and pet sometimes only used with ()

In general I like more (XXXX,YYYY) form but the other form more prevalent and
thus what I also suggested in https://github.com/bids-standard/bids-specification/pull/1450/files
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (bd08602) to head (9027f38).
Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1758   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Collaborator Author

@bids-standard/maintainers ping on this trivial PR.

@Remi-Gau Remi-Gau added the formatting Aesthetics and formatting of the spec label Apr 16, 2024
@Remi-Gau
Copy link
Collaborator

@tsalo @effigies forgot to mention this light PR to reveiw yesterday

@effigies effigies merged commit bbe2283 into bids-standard:master Apr 19, 2024
27 checks passed
@sappelhoff sappelhoff changed the title ENH: Use "Tag XXXX, YYYY" not "Tag (XXXX,YYYY)" for DICOM Tags [ENH] Use "Tag XXXX, YYYY" not "Tag (XXXX,YYYY)" for DICOM Tags Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting Aesthetics and formatting of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants