FIX: Add MRS events files, restrict sidecar metadata checks to data files #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
added
schema
effigies
requested review from
markmikkelsen
and removed request for
erdalkaraca and
tsalo
|
Also included a small patch to the rendering macro to pick up the events.tsv files:
|
tsalo
reviewed
Jul 25, 2024
| - mrs | ||
| entities: | ||
| $ref: rules.files.raw.task.events.entities | ||
| reconstruction: optional |
There was a problem hiding this comment.
Isn't reconstruction a within-acquisition entity? Like you can have rec-defaced and rec-refaced versions of a file, but they come from the same acquisition, so you wouldn't have separate events files for each one.
There was a problem hiding this comment.
It's currently permitted for MRI. I don't have a strong commitment to this, though.
markmikkelsen
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markmikkelsen With these patches, your examples in bids-standard/bids-examples#425 pass.