[FIX] Update text to reflect that BackgroundSuppressionPulseTime is recommended #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1891 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 16 16
Lines 1393 1393
=======================================
Hits 1229 1229
Misses 164 164 ☔ View full report in Codecov by Sentry. |
effigies
changed the title
Co-authored-by: Chris Markiewicz <[email protected]>
|
We have two approvals and it's been 5 days (not that the 5-day embargo is required for small bug fixes like this). I'm going to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding Issue: Background suppression timing for ASL #1842
I've changed 'required' to 'recommended' and slightly reworded the sentence.
Michael