Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Clarify Appendix II: The list of licenses only lists examples #222

Merged
merged 2 commits into from
May 17, 2019
Merged

[FIX] Clarify Appendix II: The list of licenses only lists examples #222

merged 2 commits into from
May 17, 2019

Conversation

sappelhoff
Copy link
Member

related to #218

rwblair
rwblair previously approved these changes May 9, 2019
View reviewed changes
effigies
effigies reviewed May 9, 2019
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little inclined to acknowledge the reasons that people might need to use more restrictive licenses. The current phrasing reads as a little flippant.

Here's a suggestion:

src/99-appendices/02-licenses.md Outdated Show resolved Hide resolved
@sappelhoff
Copy link
Member Author

Thanks @effigies, that makes it much clearer.

@effigies effigies requested a review from rwblair May 9, 2019 18:46
@sappelhoff sappelhoff merged commit 74744b5 into bids-standard:master May 17, 2019
@sappelhoff sappelhoff deleted the clari2 branch May 17, 2019 07:00
franklin-feingold added a commit that referenced this pull request May 17, 2019
@franklin-feingold
[DOC] Auto-generate changelog entry for PR #222
e30bb50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@rwblair rwblair rwblair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sappelhoff @effigies @rwblair