Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix Common principles Key/value files section level #328

Merged
merged 1 commit into from
Sep 11, 2019
Merged

[FIX] Fix Common principles Key/value files section level #328

merged 1 commit into from
Sep 11, 2019

Conversation

jhlegarreta
Copy link
Contributor

Fix Common principles Key/value files section level.

@jhlegarreta
[FIX] Fix Common principles Key/value files section level
9739435 
Fix `Common principles` `Key/value files` section level.
@jhlegarreta
Copy link
Contributor Author

I assume it makes sense to group all considered file formats under the same section/it was an oversight to put Key/value files in an upper level.

effigies
effigies approved these changes Sep 6, 2019
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

@sappelhoff sappelhoff merged commit 46d1fe6 into bids-standard:master Sep 11, 2019
@sappelhoff
Copy link
Member

Thanks @jhlegarreta

franklin-feingold added a commit that referenced this pull request Sep 11, 2019
@franklin-feingold
[DOC] Auto-generate changelog entry for PR #328
f0c0862
@jhlegarreta jhlegarreta deleted the FixCommonPrinciplesKeyValueFilesSectionLevel branch September 11, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@sappelhoff sappelhoff sappelhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhlegarreta @sappelhoff @effigies