-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] fix inconsistencies for task label between sections #446
[FIX] fix inconsistencies for task label between sections #446
Conversation
- to make it consistent with the filename desciptors in fMRI and other places
Thanks for the fixes @Remi-Gau! :-) Unfortunately the edits have misaligned a few table fences, Can you fix the linter, please? Also I find this new phrasing a bit hard to understand. What was your intention with this change? -The Task label is derived from this field ...
+Task label (`task-`) included in the file name is derived from this field ...
is not the task label, but rather the key of the "task key-value pair", with the label being the value. So that's why I am a bit confused. |
For this, I literally reused the wording from the fMRI section. So I suspect we might want to clarify this one to have all sections consistent. :-) How about this?
FYI the |
I see 🤔 I like your new suggestion from #446 (comment) and agree that having this consistent across the spec is good to have 👍 |
Sorry, one annoying suggestion: "non alphanumeric" should be "non-alphanumeric". And let's update the entry in MRI, to be consistent: bids-specification/src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md Line 279 in 42bcc6c
|
Can't believe I did not update the MRI section. Silly me. |
Thanks @Remi-Gau! |
Related to issue #445
task-<label>
in the filename template across sectionsTaskName
description for the JSON sidecar exactly match that of fMRI