Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Clarify requirement levels for TSV metadata fields #555

Merged
merged 3 commits into from
Aug 11, 2020
Merged

[FIX] Clarify requirement levels for TSV metadata fields #555

merged 3 commits into from
Aug 11, 2020

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Aug 2, 2020 •
edited
Loading

closes #541

Adding requirement levels for the keys in sidecar JSONs that accompany TSV files.

to do

  • make clear that typically either units or levels are used, so even when both are RECOMMENDED, doesn't mean that both are "expected" to be present

@sappelhoff sappelhoff changed the title FIX: clarify requirement levels for TSV sidecar JSONs [FIX] clarify requirement levels for TSV sidecar JSONs Aug 8, 2020
tsalo
tsalo approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@effigies effigies changed the title [FIX] clarify requirement levels for TSV sidecar JSONs [FIX] Clarify requirement levels for TSV metadata fields Aug 10, 2020
@sappelhoff sappelhoff merged commit e7ec428 into bids-standard:master Aug 11, 2020
@sappelhoff sappelhoff deleted the reqleveltsv branch August 11, 2020 08:23
bids-maintenance added a commit that referenced this pull request Aug 11, 2020
@bids-maintenance
[DOC] Auto-generate changelog entry for PR #555
dcfcbd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@tsalo tsalo tsalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating the specification of .tsv in common principles
3 participants
@sappelhoff @effigies @tsalo