-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] enable pandoc emojis for the pdf build #562
Conversation
7978d06
to
c576fc1
Compare
@Arshitha @sebastientourbier do you have an idea why it's not working for the emojis? |
Seems pandoc is still using font [lmroman10-regular]... |
On my side I tried to specify the DejaVu Sans font family by adding the following lines in
but it seems the UNICODE of these emoticons are still missing in DejaVu Sans. [WARNING] Missing character: There is no 🤔 (U+1F914) in font DejaVu Sans/OT:script=latn;language=DF |
do you get an issue for all of these unicodes? or are now some of them supported at least? |
@sappelhoff Managed to find a font (Symbola) that supports all emoji unicodes used by all contributors.
I guess we could add something similar in the circleci job. I also updated the
The emojis are now well rendered on my side. |
Not sure but quite a lot |
that sounds good!
problem is we are using a docker container that does not have
EDIT: Let me try using apt actually ... maybe I am wrong :-) |
nope :-/ we need a way to use the texlive docker image but at the same time include the new font. Probably a custom docker image is the way to go. |
Seems apt-get is well installed based on https://app.circleci.com/pipelines/github/bids-standard/bids-specification/1444/workflows/035c86b7-2a75-41a5-a26b-923b730747aa/jobs/3530 but it cannot find the package. Maybe a apt-get update would solve it.
|
@sappelhoff I could also give a try. I just would need the permission to push to this PR |
Attempt to fix issue bids-standard#551 related to PR bids-standard#562
Seems to work |
thanks for trying out! I made the adjustments, let's see if everything works out in this PR now. |
awesome, that worked -- and the font even looks nice to me! Thanks for finding it @sebastientourbier :-) I am going to add the new "all-contributors" kinds of contributions that we don't have yet, and then we can send this out to be reviewed by some other people. we don't have the following emoji keys right now (see list). I'll check the box when I added them in this PR:
Those that are not checked have not been added. Mostly because I can't think of an application of them within BIDS right now. Feel free to tell me of an example and we can add it! |
35dbb67
to
84c8261
Compare
@sebastientourbier I rebased this PR on top of your enhancement of auto-table-fixing. Please also see how I changed your Now the interesting part --> since Do you know what's going on? You can easily check by comparing the CI outputs between ... simply scroll up to the commits, find the green check marks, click on them to bring up the list of CI checks, and from there you can see the CircleCI build printed output, as well as the artifact (PDF) itself. I'd like to use edit, perhaps related: |
It seems github_markdown is handling well pipe table , being able to span long content over multiple lines but it is not the case for gfm. https://stackoverflow.com/questions/11700487/newline-in-markdown-table It is suggested to use the html flag |
merging, because spec content is untouched and we don't need excessive reviews for small infra enhancements. |
The emojis for the contributors appendix are currently not rendered.
closes #551 by trying the fix from https://superuser.com/a/1383716/1191393
Applying "DejaVu Sans" may lead to correct rendering ... and that font should be included in the texlive docker --> https://tug.org/FontCatalogue/sansseriffonts.html but it's not working 🤷♂️ ... maybe https://ipfs-sec.stackexchange.cloudflare-ipfs.com/tex/A/question/234786.html as a fix?
done in this PR:
start using gfm instead of the deprecated github_markdown for rendering PDFreverted, becausegfm
does not seem to support the table wrap in the same way asmarkdown_github
?\|