Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Rewrite inheritance principle #946

Merged

Commits on Dec 5, 2021

  1. Configuration menu
    Copy the full SHA
    c230301 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Configuration menu
    Copy the full SHA
    2202697 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2021

  1. Inheritance principle: Use bullet points

    Co-authored-by: Remi Gau <[email protected]>
    Lestropie and Remi-Gau authored Dec 12, 2021
    Configuration menu
    Copy the full SHA
    0abc930 View commit details
    Browse the repository at this point in the history
  2. Inheritance principle: Multiple changes

    - Change primary rules from dot points to enumerations, and reference rules by number where applicable.
    - Move from subsequent text into this list rules relating to improper placement of metadata files within the directory structure, and not permitting multiple applicable files at one level of the hierarchy.
    - Add "corollaries" section incorporating text relating to interpretation and consequences of the rules, separating them from subsequent examples.
    Lestropie committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    1bcf1b5 View commit details
    Browse the repository at this point in the history
  3. Inheritance principle: Move to follow "file formation specification"

    As the inheritance principle makes reference to tabular files and JSON key-value dictionaries, but there are no such references in the opposite direction, these files should be defined prior to introduction of the Inheritance Principle.
    Lestropie committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    7f52984 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Configuration menu
    Copy the full SHA
    399a907 View commit details
    Browse the repository at this point in the history
  2. Inheritance principle: Tweak to corollary

    Having a metadata file applicable to multiple data files can occur not only at one level of the directory hierarchy, but additionally to many data files at lower levels of the hierarchy.
    Lestropie committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8091e3c View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. Common principles: Harmonize "file name" -> "filename"

    Resolves bids-standard#946 with bids-standard#962.
    
    Co-authored-by: Yaroslav Halchenko <[email protected]>
    Lestropie and yarikoptic authored Dec 19, 2021
    Configuration menu
    Copy the full SHA
    1839b58 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Configuration menu
    Copy the full SHA
    01aa790 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ba50a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Inheritance principle: Minor changes and formatting

    Co-authored-by: Stefan Appelhoff <[email protected]>
    Lestropie and sappelhoff committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    7bc7ad5 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Inheritance principle: No unsetting as corollary

    The rule regarding the fact that it is not possible to "unset" a key-value pair from a JSON file from higher in the filesystem hierarchy is here moved to the "corollaries" section. This is because this behaviour is a natural consequence of loading consecutive JSON files using a simple merge operation, and the absence of an equivalent to Python' "None" in the JSON specification.
    Lestropie committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    fc604ef View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Configuration menu
    Copy the full SHA
    2590d0a View commit details
    Browse the repository at this point in the history
  2. Merge branch 'rewrite_inheritance_principle' into inheritance_unsetti…

    …ng_corollary
    
    Conflicts:
    	src/02-common-principles.md
    Lestropie committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    1141cf7 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Merge pull request #3 from Lestropie/inheritance_unsetting_corollary

    Inheritance principle: No unsetting as corollary
    Lestropie authored Jan 18, 2022
    Configuration menu
    Copy the full SHA
    5475322 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Configuration menu
    Copy the full SHA
    97d319b View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Configuration menu
    Copy the full SHA
    33cc25a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Inheritance principle: Use American spelling

    Co-authored-by: Stefan Appelhoff <[email protected]>
    Lestropie and sappelhoff authored Feb 1, 2022
    Configuration menu
    Copy the full SHA
    7af3e05 View commit details
    Browse the repository at this point in the history
  2. Inheritance principle: Fix enumeration cross-reference

    Co-authored-by: Stefan Appelhoff <[email protected]>
    Lestropie and sappelhoff authored Feb 1, 2022
    Configuration menu
    Copy the full SHA
    525ab87 View commit details
    Browse the repository at this point in the history