Top level /scans.json is ignored/causes error although recommended to be used in the next msg

[yarikoptic]

$ singularity exec -e -B $PWD ~yoh/bin/bids-validator.simg  bids-validator -c .bids-validator.cfg $PWD
1: [ERR] Files with such naming scheme are not part of BIDS specification. This error is most commonly caused by typos in file names that make them not BIDS compatible. Please consult the specification and make sure your files are named correctly. If this is not a file naming issue (for example when including files not yet covered by the BIDS specification) you should include a ".bidsignore" file in your dataset (see https://github.com/bids-standard/bids-validator#bidsignore for details). Please note that derived (processed) data should be placed in /derivatives folder and source data (such as DICOMS or behavioural logs in proprietary formats) should be placed in the /sourcedata folder. (code: 1 - NOT_INCLUDED)
                ./scans.json
                        Evidence: scans.json

1: [WARN] Tabular file contains custom columns not described in a data dictionary (code: 82 - CUSTOM_COLUMN_WITHOUT_DESCRIPTION)
   ./sub-sid000003/ses-XXX/sub-sid000003_ses-XXX_scans.tsv
         Evidence: Columns: operator, randstr not defined, please define in: /scans.json, /sub-sid000003/sub-sid000003_scans.json,/sub-sid000003/ses-XXX/sub-sid000003_ses-XXX_scans.json
...

copying scans.tsv under a corresponding subject's directory near the _scans.tsv resolves it for that subject.

[yarikoptic]

could it be upgraded to "top one" priority (unless somehow it is a complicated fix)? ;-) I keep tripping on this one.

[sappelhoff]

probably related to #1119

[sappelhoff]

same as in #1119 (comment), this can probably be fixed by adding scans.json to this part of the code:

bids-validator/bids-validator/bids_validator/rules/top_level_rules.json

Lines 1 to 19 in 5d3835b

	{
	"root_top": {
	"regexp": "^[\\/\\\\]?(@@@_root_files_@@@)$",
	"tokens": {
	"@@@_root_files_@@@": [
	"README",
	"CHANGES",
	"LICENSE",
	"dataset_description.json",
	"genetic_info.json",
	"participants.tsv",
	"participants.json",
	"phasediff.json",
	"phase1.json",
	"phase2.json",
	"fieldmap.json"
	]
	}
	},

[effigies]

Makes sense to me.