allow events.json and scans.json to be defined at the top level + tests #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1200 +/- ##
=======================================
Coverage 82.53% 82.53%
=======================================
Files 78 78
Lines 2622 2622
Branches 598 598
=======================================
Hits 2164 2164
Misses 369 369
Partials 89 89 Continue to review full report at Codecov.
|
sappelhoff
commented
Feb 25, 2021
effigies
approved these changes
Feb 25, 2021
|
Got an approving review by Remi on another channel, so I am going to merge. |
rob-luke
pushed a commit
to rob-luke/bids-validator
that referenced
this pull request
Jan 31, 2022
…ts (bids-standard#1200) * allow events.json and scans.json to be defined at the top level + tests * Update bids-validator/tests/type.spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #742
closes #1119
if all events.tsv (or scans.tsv) files can be explained using a single accompanying JSON, then it would be valid BIDS to place this JSON at the root (top level), and let inheritance take care of the rest.