Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add values to associations.bvals, fix misnamed variables #1955

Merged
merged 1 commit into from
May 23, 2024

Conversation

effigies
Copy link
Collaborator

Allows bids-standard/bids-specification#1754 to be validated.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.99%. Comparing base (43a7117) to head (173ecc2).

Files Patch % Lines
bids-validator/src/schema/associations.ts 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1955      +/-   ##
==========================================
+ Coverage   85.68%   86.99%   +1.31%     
==========================================
  Files          91      130      +39     
  Lines        3792     6181    +2389     
  Branches     1220     1501     +281     
==========================================
+ Hits         3249     5377    +2128     
- Misses        457      713     +256     
- Partials       86       91       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit fffc35c into bids-standard:master May 23, 2024
29 of 33 checks passed
@effigies effigies deleted the enh/bval-values branch May 23, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant