fix: avoid Maximum call stack size exceeded #2162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using spread syntax (
...SomeIterable
) with a long list inside a function call (in this case,Array.prototype.push
) can result in a "Maximum call stack size exceeded" error. But this is not a problem inside array literals.I ran into this when running
bids-validator
on the command-line, on a relatively small dataset (~350 subjects, each with ~2 sessions, all sessions labeled with unique dates because no-one understands that part of the standard).Before the fix:
The error disappeared when I applied this change directly in the compiled
cli.js
around line 136164.There are a few other cases of the
push(...SomeIterable)
pattern elsewhere in the repo, but I'm not confident enough to touch them.