BF: missing period before {extension} group for some dwi/ files #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyarkoni
approved these changes
May 10, 2019
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
=======================================
Coverage 62.56% 62.56%
=======================================
Files 27 27
Lines 4573 4573
Branches 1177 1177
=======================================
Hits 2861 2861
Misses 1429 1429
Partials 283 283
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
=======================================
Coverage 62.56% 62.56%
=======================================
Files 27 27
Lines 4573 4573
Branches 1177 1177
=======================================
Hits 2861 2861
Misses 1429 1429
Partials 283 283
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered if there is some kind of way to automate testing of those... e.g. I think all files under sub* directories should have extension defined - we could check.
There is also a question of either extension should or should not contain a leading period but that is orthogonal to this, just linking related changes ;)