Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml #116

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Use pyproject.toml #116

merged 2 commits into from
Feb 12, 2024

Conversation

cbrnr
Copy link
Collaborator

@cbrnr cbrnr commented Feb 11, 2024

And while we're at it, we can also replace the legacy setup.{cfg,py} with pyproject.toml.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1a6c79) 100.00% compared to head (4c77dde) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          634       632    -2     
=========================================
- Hits           634       632    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbrnr
Copy link
Collaborator Author

cbrnr commented Feb 11, 2024

Please review extra carefully, since I cannot run the other two workflows (python_build.yml and python_publish.yml. I hope I didn't forget and/or screw anything up.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sappelhoff sappelhoff merged commit efaa0bd into bids-standard:main Feb 12, 2024
18 checks passed
@sappelhoff
Copy link
Member

Thanks @cbrnr

@cbrnr cbrnr deleted the pyproject branch February 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants