Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meas_date is now a datetime.datetime object #40

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

cbrnr
Copy link
Collaborator

@cbrnr cbrnr commented Mar 30, 2020

fixes #42

Starting with MNE 0.20, raw.info["meas_date"] is now a datetime.datetime object. This PR fixes a failing test because of that change.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #40 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   95.45%   95.39%   -0.07%     
==========================================
  Files           3        3              
  Lines         220      217       -3     
==========================================
- Hits          210      207       -3     
  Misses         10       10              
Impacted Files Coverage Δ
pybv/tests/test_bv_writer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b49585...41c744a. Read the comment docs.

@sappelhoff sappelhoff merged commit 6a15723 into bids-standard:master Mar 30, 2020
@sappelhoff
Copy link
Member

Thanks @cbrnr

@cbrnr cbrnr deleted the meas_date-datetime branch March 30, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code (at least testing) for mne==0.20
2 participants