Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance PR #43

Merged
merged 7 commits into from
Jun 3, 2020
Merged

maintenance PR #43

merged 7 commits into from
Jun 3, 2020

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Jun 2, 2020

I'll finish this piece by piece

  • add conda-forge badge and conda install instructions
  • update BrainVision Core Data Format specification (the spec to which this code should adhere)
  • move from circleCI to github actions (testing on win, macos, linux instead of only linux)
  • test for different mne and python versions
  • get coverage to 100%
  • test the read example we advertise in the README

Also I wrote to readthedocs to please enable Pull Request Build Artifacts for us ... this will replace the circleci artifact. (for a preview to how it looks, see the "checks" section in this PR)

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #43 into master will increase coverage by 4.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #43      +/-   ##
===========================================
+ Coverage   95.33%   100.00%   +4.66%     
===========================================
  Files           3         3              
  Lines         236       254      +18     
===========================================
+ Hits          225       254      +29     
+ Misses         11         0      -11     
Impacted Files Coverage Δ
pybv/__init__.py 100.00% <100.00%> (ø)
pybv/io.py 100.00% <100.00%> (+7.09%) ⬆️
pybv/tests/test_bv_writer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e25a65...d5588d3. Read the comment docs.

@sappelhoff sappelhoff marked this pull request as ready for review June 2, 2020 19:33
@sappelhoff
Copy link
Member Author

got a reply from Readthedocs, so testing whether this works now :)

Hi Stefan!
I've just enabled the feature for you, you should be able to enabled the pull request builds now.
You can find our docs on this feature here: https://docs.readthedocs.io/en/latest/guides/autobuild-docs-for-pull-requests.html, let us know if you have any more questions or have any feedback!
Regards,
Anthony

@sappelhoff sappelhoff closed this Jun 3, 2020
@sappelhoff sappelhoff reopened this Jun 3, 2020
@sappelhoff sappelhoff force-pushed the maint branch 2 times, most recently from bbb0d48 to d5588d3 Compare June 3, 2020 08:03
@sappelhoff sappelhoff merged commit 005241a into master Jun 3, 2020
@sappelhoff sappelhoff deleted the maint branch June 3, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant