MISC maintenance

[sappelhoff]

closes #55

• replaces our custom tmpdir hacking with the pytest tmpdir fixture
• uses pytest.mark.parametrize for one test to make it (1) more concise, (2) more informative if failed
• "switches on" the comma test, wich will fail until [MRG] FIX: Support commas in BrainVision channel names, event types, and event descriptions mne-tools/mne-python#8492 is merged

I plan that this is the last PR before release 0.4 #60

[cbrnr]

How does this work? You just add one parameter called tmpdir and that's it?

[sappelhoff]

How does this work? You just add one parameter called tmpdir and that's it?

yes, and then pytest creates the directory, available from the pathlib.Path called tmpdir and also deletes that dir after the run succeeds or fails. Super convenient

[cbrnr]

I don't think it cleans up after itself though, because it keeps the three most recently created directories. We might want to change that to delete a temp directory immediately (see pytest-dev/pytest#543 (comment)).

[sappelhoff]

We might want to change that to delete a temp directory immediately

I thought that was a good idea and tried to add a setup.cfg like:

[tool:pytest]
tmp_keep=1

but it doesn't work, and this is why:

pytest-dev/pytest#543 (comment)

:)

EDIT: the 3 test directories that are being kept at most, eat up 63.7 MB in the /tmp directory. I don't know for how long they stay in that directory by system default - it sounds like something that is cleaned regularly by the OS.

[cbrnr]

Should've read it till the end I guess 😉. LGTM!