Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated logical test in _chk_events #95

Merged
merged 6 commits into from
Jul 5, 2022
Merged

updated logical test in _chk_events #95

merged 6 commits into from
Jul 5, 2022

Conversation

compmonks
Copy link
Contributor

event["description"] can be >= 0 instead of strictly >1 for more tolerance in labeling events

event["description"] can be >= 0 instead of strictly >1 for more tolerance in labeling events
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #95 (77a6d9f) into main (1b4a89d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          625       625           
=========================================
  Hits           625       625           
Impacted Files Coverage Δ
pybv/tests/test_bv_writer.py 100.00% <ø> (ø)
pybv/io.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4a89d...77a6d9f. Read the comment docs.

@sappelhoff
Copy link
Member

Thanks! Please add yourself here:

and add a changelog entry here:

@cbrnr
Copy link
Collaborator

cbrnr commented Jul 4, 2022

Can you also update the docstring (0 is not a positive integer)?

@sappelhoff sappelhoff merged commit 8035d9b into bids-standard:main Jul 5, 2022
@sappelhoff
Copy link
Member

Thanks @compmonks

@cbrnr
Copy link
Collaborator

cbrnr commented Jul 5, 2022

@sappelhoff do you have time to make a quick bugfix release?

@sappelhoff
Copy link
Member

I can do one after #94 is fixed 👍

@cbrnr
Copy link
Collaborator

cbrnr commented Jul 5, 2022

Yes, I thought that this has already been fixed by #95. I've fixed it in #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants