test(component): refactor Button component tests #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bc-alexsaiannyi if this is a draft PR, would you mind using the Draft Pull Request feature instead of appending |
bc-alexsaiannyi
force-pushed
the
bigdesign-635-button
branch
from
36652ef
to
07824c6
Compare
bc-alexsaiannyi
changed the title
|
@chanceaclark , sorry. I will do it next time. This time you can check my changes) |
|
|
||
| fireEvent.click(button); | ||
| fireEvent.click(screen.getByRole<HTMLButtonElement>('button')); |
There was a problem hiding this comment.
Let's also switch out usages of fireEvent with userEvent.
There was a problem hiding this comment.
Yeah, it's a good point. I also see that we will need @testing-library/user-event package for this purpose. Is it ok to proceed?
| <Button iconLeft={plusIcon} iconOnly={plusIcon} iconRight={plusIcon}> | ||
| Button | ||
| </Button>, | ||
| ); | ||
|
|
||
| expect(getAllByTestId('icon-only').length).toBe(1); | ||
| expect(screen.getAllByTestId('icon-only').length).toBe(1); |
There was a problem hiding this comment.
Suggested change
| expect(screen.getAllByTestId('icon-only').length).toBe(1); | |
| expect(screen.getAllByTestId('icon-only')).toHaveLength(1); |
bc-alexsaiannyi
force-pushed
the
bigdesign-635-button
branch
3 times, most recently
from
b0b246d
to
1525ec8
Compare
bc-alexsaiannyi
force-pushed
the
bigdesign-635-button
branch
from
1525ec8
to
86d0cbb
Compare
chanceaclark
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is aimed to refactor Button component's tests according to best practices. We take into account recommendations from Kent C. Dodds article. For instance, using
containerforquery-ing elements has been removed. Instead, we replace it withscreen.NOTE: We've also switched to using
userEventinstead offireEventwhenever it's possible. For this purpose a package@testing-library/user-eventhas been added andyarn.lockis updated as well.Why?
the changes are based on GitHub issue and PRs will be open for each component separately.
Testing/Proof
The tests have been successfully run locally.