fix(core): improve redirect behavior after creating account #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
🦋 Changeset detectedLatest commit: ec364c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
859a2e7
to
f213960
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
2 times, most recently
from
efd4eff
to
8125b0d
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
8125b0d
to
a61f563
Compare
bc-yevhenii-buliuk
requested review from
yurytut1993 and
bc-alexsaiannyi
and removed request for
a team
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
a61f563
to
8089ce1
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
2 times, most recently
from
e69cf33
to
6c7ee19
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
6c7ee19
to
6889b86
Compare
bc-yevhenii-buliuk
changed the title
|
This PR implements appearance of success banner by adding a search parameter to the URL. Thanks to this parameter we can control banner appearance. Another possible solution to implement was to use the context and change its status to Open to suggestions, thanks! |
core/app/[locale]/(default)/account/(tabs)/_components/message-wrapper.tsx
Outdated
Show resolved
Hide resolved
core/app/[locale]/(default)/account/(tabs)/_components/message-wrapper.tsx
Outdated
Show resolved
Hide resolved
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
9de4300
to
0382b31
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
0382b31
to
df59e5d
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
df59e5d
to
6479c93
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
6479c93
to
46cbee9
Compare
bc-alexsaiannyi
approved these changes
Sep 3, 2024
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
46cbee9
to
30fbf5d
Compare
yurytut1993
approved these changes
Sep 3, 2024
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
be21cf6
to
94a90d3
Compare
bc-yevhenii-buliuk
force-pushed
the
fix-create-account-redirect
branch
from
94a90d3
to
ec364c8
Compare
Merged
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-oxswlvsl3-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR improves redirect behavior after creating account, namely, it adds a banner about the successful creation of an account.
Testing
locally
before:
create-account-redirect.mov
after:
fix-create-account-redirect.mov