Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): rename DEFAULT_REVALIDATE_TARGET env variable #1317

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Rename NEXT_PUBLIC_DEFAULT_REVALIDATE_TARGET to DEFAULT_REVALIDATE_TARGET since we don't need this exposed to the client.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team as a code owner August 29, 2024 20:02
Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 05de3f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 8:03pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Aug 29, 2024 8:03pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Aug 29, 2024 8:03pm
catalyst-au ⬜️ Ignored (Inspect) Aug 29, 2024 8:03pm
catalyst-staging ⬜️ Ignored (Inspect) Aug 29, 2024 8:03pm
catalyst-test-store ⬜️ Ignored (Inspect) Aug 29, 2024 8:03pm
catalyst-uk ⬜️ Ignored (Inspect) Aug 29, 2024 8:03pm
catalyst-unstable ⬜️ Ignored (Inspect) Aug 29, 2024 8:03pm

@chanceaclark
Copy link
Contributor

Make sure to update Vercel env vars too

@jorgemoya jorgemoya added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 7802361 Aug 29, 2024
14 checks passed
@jorgemoya jorgemoya deleted the rename-revalidate-target-var branch August 29, 2024 20:16
@github-actions github-actions bot mentioned this pull request Aug 28, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-3y0cwu2bw-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 89
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants