Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not write access token to env file #1365

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

matthewvolk
Copy link
Contributor

What/Why?

A BigCommerce access token is no longer required to run Catalyst. If a merchant wants to use an access token, they should manually create one following: https://www.catalyst.dev/docs/environment-variables#bigcommerce_access_token

Testing

Built and ran node packages/create-catalyst/bin/index.cjs locally, checked .env.local in created project to confirm access token not present:

BIGCOMMERCE_STORE_HASH=storehash
BIGCOMMERCE_CHANNEL_ID=12345
BIGCOMMERCE_CUSTOMER_IMPERSONATION_TOKEN=eyJ...

AUTH_SECRET=e85b...
CLIENT_LOGGER=false
ENABLE_ADMIN_ROUTE=true
NEXT_PUBLIC_DEFAULT_REVALIDATE_TARGET=3600

@matthewvolk matthewvolk requested a review from a team as a code owner September 13, 2024 14:25
Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 93049aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/create-catalyst Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 2:25pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Sep 13, 2024 2:25pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Sep 13, 2024 2:25pm
catalyst-au ⬜️ Ignored (Inspect) Sep 13, 2024 2:25pm
catalyst-test-store ⬜️ Ignored (Inspect) Sep 13, 2024 2:25pm
catalyst-uk ⬜️ Ignored (Inspect) Sep 13, 2024 2:25pm
catalyst-unstable ⬜️ Ignored (Inspect) Sep 13, 2024 2:25pm

Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I thought I did this already, but seems not 😅 Thanks for doing this!

@matthewvolk matthewvolk added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 896b4d3 Sep 13, 2024
13 checks passed
@matthewvolk matthewvolk deleted the fix/cli-access-token branch September 13, 2024 14:46
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-gnt8s739x-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 90
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants