feat(core): add wishlist details #1405
Open
+678
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 287d75b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yurytut1993
force-pushed
the
wishlist
branch
from
c28c716
to
9257afa
Compare
yurytut1993
force-pushed
the
wishlist-details
branch
2 times, most recently
from
085f565
to
3a393e3
Compare
yurytut1993
force-pushed
the
wishlist-details
branch
from
3a393e3
to
59b6b54
Compare
yurytut1993
force-pushed
the
wishlist
branch
from
9257afa
to
9cacae6
Compare
yurytut1993
force-pushed
the
wishlist-details
branch
from
59b6b54
to
db577e6
Compare
yurytut1993
force-pushed
the
wishlist-details
branch
from
db577e6
to
16c6cce
Compare
yurytut1993
force-pushed
the
wishlist-details
branch
from
16c6cce
to
ac6b5ec
Compare
yurytut1993
force-pushed
the
wishlist-details
branch
from
ac6b5ec
to
9af976b
Compare
yurytut1993
commented
Oct 3, 2024
Comment on lines
+52
to
+60
| const timer = setTimeout(() => { | ||
| toast.dismiss(toastId); | ||
|
|
||
| onWishlistItemDeleted(itemEntityId); | ||
|
|
||
| void deleteWishlistItem({ | ||
| input: { entityId, itemEntityIds: [itemEntityId] }, | ||
| }); | ||
| }, 5000); |
There was a problem hiding this comment.
This is workaround for current react-hot-toast library we use. In future we may change it to react-toastify that has useful onClose callback needed to pass deleteWishlistItem mutation in
yurytut1993
force-pushed
the
wishlist-details
branch
from
9af976b
to
ee6718e
Compare
yurytut1993
force-pushed
the
wishlist-details
branch
from
ee6718e
to
bae8f05
Compare
yurytut1993
force-pushed
the
wishlist-details
branch
from
bae8f05
to
4abc437
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-pwsh1330w-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This pr adds Wishlist Details Page to Account Wishlist and fix minor translation issues for Wishlist Book
Testing
Locally