Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): move script binding to bodl initialization #1422

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

chanceaclark
Copy link
Contributor

What/Why?

Pulls setting up the script of bodl events and gtag into the Bodl class. This helps create a consistent location for where we are binding the DOM scripts.

Testing

Screenshot 2024-10-02 at 13 28 10

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: a499896

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:43pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:43pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 2:43pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 2:43pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 2:43pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 2:43pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 2:43pm

@chanceaclark chanceaclark added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 3f8bf59 Oct 4, 2024
14 checks passed
@chanceaclark chanceaclark deleted the refactor/bodl-2 branch October 4, 2024 15:27
Copy link
Contributor

github-actions bot commented Oct 4, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-1389pkiju-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 77
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 89
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants