-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move margins to button in slideshow #1643
base: vibes/soul-with-makeswift
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm-lock
shouldn't need to be updated. Component changes look good tho!
@jorgemoya I assume it changed the lock file by me just running I also was about to ask in Slack what I should do about the lint failures in the build that aren't related to my PR. |
I would just undo the file and push it back up. We can then investigate if we need to update the lock file. |
What/Why?
In the Slideshow component, if a slide description is removed, there was no spacing between the title and button. Margin classes were changed to ensure the title, description, and button had the proper spacing between them at all times.
Testing
View the Slideshow component and hide any slide description.