Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move margins to button in slideshow #1643

Open
wants to merge 2 commits into
base: vibes/soul-with-makeswift
Choose a base branch
from

Conversation

andrewreifman
Copy link
Contributor

What/Why?

In the Slideshow component, if a slide description is removed, there was no spacing between the title and button. Margin classes were changed to ensure the title, description, and button had the proper spacing between them at all times.

Testing

View the Slideshow component and hide any slide description.

@andrewreifman andrewreifman requested a review from a team as a code owner November 14, 2024 21:50
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: ecaddfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 11:12pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 14, 2024 11:12pm
catalyst-au ⬜️ Ignored (Inspect) Nov 14, 2024 11:12pm
catalyst-soul ⬜️ Ignored (Inspect) Nov 14, 2024 11:12pm
catalyst-uk ⬜️ Ignored (Inspect) Nov 14, 2024 11:12pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 11:12pm

Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm-lock shouldn't need to be updated. Component changes look good tho!

@andrewreifman
Copy link
Contributor Author

pnpm-lock shouldn't need to be updated. Component changes look good tho!

@jorgemoya I assume it changed the lock file by me just running pnpm install. Do I just need to undo that change in the file and push it back up?

I also was about to ask in Slack what I should do about the lint failures in the build that aren't related to my PR.

@jorgemoya
Copy link
Contributor

pnpm-lock shouldn't need to be updated. Component changes look good tho!

@jorgemoya I assume it changed the lock file by me just running pnpm install. Do I just need to undo that change in the file and push it back up?

I also was about to ask in Slack what I should do about the lint failures in the build that aren't related to my PR.

I would just undo the file and push it back up. We can then investigate if we need to update the lock file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants