feat(extension): CHECKOUT-000 Pass consignment includes to reload checkout command #1785
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchin
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Also, can you check if it fixes the issue @petercossey's describing?
| void checkoutService.loadCheckout(checkoutService.getState().data.getCheckout()?.id, { | ||
| params: { | ||
| // eslint-disable-next-line | ||
| include: ['consignments.availableShippingOptions'] as any, |
There was a problem hiding this comment.
Suggested change
| include: ['consignments.availableShippingOptions'] as any, | |
| include: [CheckoutIncludes.AvailableShippingOptions], |
There was a problem hiding this comment.
I was going by this https://github.com/bigcommerce/checkout-js/blob/master/packages/core/src/app/checkout/Checkout.tsx#L203 but just tried to use the enum and seems to work fine. Seems like we have fixed the enum export issue overtime 😄
There was a problem hiding this comment.
For some reason this enum usage throws an undefined error where CheckoutIncludes is not defined. Might need to investigate it later.
davidchin
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Pass consignment includes to reload checkout command.
Why?
Based on feedback of the extension is able to select shipping option, then reload command can take the shopper back to shipping step since shipping options are not reloaded on calling
reloadCheckoutcommand.Testing / Proof
@bigcommerce/team-checkout