Skip to content

Commit

Permalink
fix(storefront): BCTHEME-383 Selecting certain option types pushes wi…
Browse files Browse the repository at this point in the history
…ndow view to the bottom of the page (#1959)
  • Loading branch information
BC-tymurbiedukhin authored Jan 19, 2021
1 parent 32bc445 commit 13f73b3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed selecting certain option types which pushes window view to the bottom of the page. [#1959](https://github.com/bigcommerce/cornerstone/pull/1959)
- Fixed case when default option is out of stock add to cart button does not populate for in stock options. [#1955](https://github.com/bigcommerce/cornerstone/pull/1955)
- Dots on carousel should have similar colours as other slider controls. [#1958](https://github.com/bigcommerce/cornerstone/pull/1958)
- PDP - Fixed Empty "Description" Hiding All Tabs When in Tab View. [#1947](https://github.com/bigcommerce/cornerstone/pull/1947)
Expand Down
7 changes: 5 additions & 2 deletions assets/scss/components/citadel/forms/_forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@

.form-checkbox,
.form-radio {
bottom: 0.5rem;
left: 0.5rem;

+ .form-label {

Expand All @@ -91,6 +89,11 @@
.form-option-wrapper {
position: relative;
display: inline-block;

& .form-radio, & .form-checkbox {
bottom: 0.5rem;
left: 0.5rem;
}
}

// Citadel form-actions
Expand Down

0 comments on commit 13f73b3

Please sign in to comment.