fix(storefront): BCTHEME-535 Translation Gap: Cart -> Shipping estima…

…tor error messages.
bigcommerce · May 25, 2021 · 1e2666f · 1e2666f
1 parent 31ac15a
commit 1e2666f
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Translation Gap: Cart -> Shipping estimator error messages. [#2065](https://github.com/bigcommerce/cornerstone/pull/2065)
 - Added settings for payment banners. [#2021](https://github.com/bigcommerce/cornerstone/pull/2021)
 - Use https:// for schema markup. [#2039](https://github.com/bigcommerce/cornerstone/pull/2039)
 - Update focus tooltip styles contrast to achieve accessibility AA Complaince. [#2047](https://github.com/bigcommerce/cornerstone/pull/2047)

diff --git a/assets/js/theme/cart.js b/assets/js/theme/cart.js
@@ -456,6 +456,10 @@ export default class Cart extends PageManager {
         this.bindGiftCertificateEvents();
 
         // initiate shipping estimator module
-        this.shippingEstimator = new ShippingEstimator($('[data-shipping-estimator]'));
+        const shippingErrorMessages = {
+            country: this.context.shippingCountryErrorMessage,
+            province: this.context.shippingProvinceErrorMessage
+        }
+        this.shippingEstimator = new ShippingEstimator($('[data-shipping-estimator]'), shippingErrorMessages);
     }
 }
diff --git a/assets/js/theme/cart/shipping-estimator.js b/assets/js/theme/cart/shipping-estimator.js
@@ -6,11 +6,12 @@ import collapsibleFactory from '../common/collapsible';
 import swal from '../global/sweet-alert';
 
 export default class ShippingEstimator {
-    constructor($element) {
+    constructor($element, shippingErrorMessages) {
         this.$element = $element;
 
         this.$state = $('[data-field-type="State"]', this.$element);
         this.isEstimatorFormOpened = false;
+        this.shippingErrorMessages = shippingErrorMessages;
         this.initFormValidation();
         this.bindStateCountryChange();
         this.bindEstimatorEvents();
@@ -63,7 +64,7 @@ export default class ShippingEstimator {
 
                     cb(result);
                 },
-                errorMessage: 'The \'Country\' field cannot be blank.',
+                errorMessage: this.shippingErrorMessages.country
             },
         ]);
     }
@@ -85,7 +86,7 @@ export default class ShippingEstimator {
 
                     cb(result);
                 },
-                errorMessage: 'The \'State/Province\' field cannot be blank.',
+                errorMessage: this.shippingErrorMessages.province
             },
         ]);
     }

diff --git a/lang/en.json b/lang/en.json
@@ -105,7 +105,9 @@
             "zip_postal_code": "Zip/postcode",
             "free_shipping": "Free shipping",
             "hide_ups_rates": "Hide UPS Rates",
-            "show_ups_rates": "Show UPS Rates"
+            "show_ups_rates": "Show UPS Rates",
+            "empty_country_error": "The Country field cannot be blank.",
+            "empty_province_error": "The State/Province field cannot be blank."
         },
         "gift_wrapping": {
             "title": "Gift Wrapping",

diff --git a/templates/components/cart/shipping-estimator.html b/templates/components/cart/shipping-estimator.html
@@ -1,3 +1,6 @@
+{{inject 'shippingCountryErrorMessage' (lang 'cart.shipping_estimator.empty_country_error')}}
+{{inject 'shippingProvinceErrorMessage' (lang 'cart.shipping_estimator.empty_province_error')}}
+
 {{#if shipping_cost}}
     <div class="cart-total-value">
         <div class="subtotal shipping-estimate-show">