Skip to content

Commit

Permalink
Update blog component to use H1 tags on posts
Browse files Browse the repository at this point in the history
  • Loading branch information
sacr3dc0w committed Feb 23, 2022
1 parent 7410ea4 commit 34fe1af
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Update blog component to use H1 tags on posts [#2179](https://github.com/bigcommerce/cornerstone/issues/2179)
- Remove Compare Form. [#2162](https://github.com/bigcommerce/cornerstone/pull/2162)
- Fixed password complexity error not displaying the complexity rules set in the store settings [#2117](https://github.com/bigcommerce/cornerstone/pull/2117)
- Translation updates February 2022. [#2177](https://github.com/bigcommerce/cornerstone/pull/2177)
Expand Down
4 changes: 2 additions & 2 deletions templates/components/blog/post.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@

<div class="blog-post-body">
<header class="blog-header">
<h2 class="blog-title">
<h{{#if is_blog_post}}1{{else}}2{{/if}} class="blog-title">
<a href="{{post.url}}">{{post.title}}</a>
</h2>
</h{{#if is_blog_post}}1{{else}}2{{/if}}>
<p class="blog-date">{{#if post.author}}{{lang 'blog.posted_by' name=post.author}} on {{/if}}{{post.date_published}}</p>
</header>

Expand Down
2 changes: 1 addition & 1 deletion templates/pages/blog-post.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

{{> components/common/breadcrumbs breadcrumbs=breadcrumbs}}

{{> components/blog/post post=blog.post show_tags=true}}
{{> components/blog/post post=blog.post show_tags=true is_blog_post=true}}

{{/partial}}
{{> layout/base}}

0 comments on commit 34fe1af

Please sign in to comment.