Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-1076 Unable to navigate to home page from search results page after clicking Back button on browser. #2238

Merged
merged 3 commits into from
Jul 22, 2022
Merged

fix(storefront): BCTHEME-1076 Unable to navigate to home page from search results page after clicking Back button on browser. #2238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2462179
fix(storefront): BCTHEME-1076 Unable to navigate to home page from se…
Jul 19, 2022
b86488a
Merge branch 'master' into BCTHEME-1076
bc-yevhenii-buliuk Jul 20, 2022
28c7971
Merge branch 'master' into BCTHEME-1076
bc-yevhenii-buliuk Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Unable to navigate to home page from search results page after clicking Back button on browser. [#2238](https://github.com/bigcommerce/cornerstone/issues/2238)
- Cannot Vault 16-digit Diners Club cards - creditcards module version is out of date [#2239](https://github.com/bigcommerce/cornerstone/issues/2239)
- Incorrect translation key for Diners Club card type. [#2237](https://github.com/bigcommerce/cornerstone/issues/2237).
- Bump webpack-bundle-analyzer [#2229]https://github.com/bigcommerce/cornerstone/pull/2229
Expand Down
4 changes: 1 addition & 3 deletions assets/js/theme/global/quick-search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import _ from 'lodash';
import utils from '@bigcommerce/stencil-utils';
import StencilDropDown from './stencil-dropdown';
import urlUtils from '../common/utils/url-utils';

export default function () {
const TOP_STYLING = 'top: 49px;';
Expand Down Expand Up @@ -88,7 +87,6 @@ export default function () {
return;
}

urlUtils.goToUrl(`${searchUrl}?search_query=${encodeURIComponent(searchQuery)}`);
window.location.reload();
window.location.href = `${searchUrl}?search_query=${encodeURIComponent(searchQuery)}`;
});
}