Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1769 ADA Compliance - Expandable items should be read by screen reader #2422

Merged

Conversation

bc-yevhenii-buliuk
Copy link
Contributor

@bc-yevhenii-buliuk bc-yevhenii-buliuk commented Jan 29, 2024

What?

This PR adds appropriate aria attributes to each element that controls expandable content that are specified by screen reader.

Tickets / Documentation

Screen records

1769_add_aria_attrs.mov

@bc-yevhenii-buliuk bc-yevhenii-buliuk self-assigned this Jan 29, 2024
@bc-yevhenii-buliuk bc-yevhenii-buliuk added the draft Ready for initial review label Jan 29, 2024
@bc-yevhenii-buliuk bc-yevhenii-buliuk requested a review from a team January 29, 2024 14:22
@bc-yevhenii-buliuk bc-yevhenii-buliuk changed the title [DRAFT] fix(storefront): BCTHEME-1769 ADA Compliance - Expandable items should be read by screen reader fix(storefront): BCTHEME-1769 ADA Compliance - Expandable items should be read by screen reader Jan 30, 2024
@bc-yevhenii-buliuk bc-yevhenii-buliuk removed the draft Ready for initial review label Jan 30, 2024
Copy link
Contributor

@yurytut1993 yurytut1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants