-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B2B-1237: [update] sync recent updates from B2B Edition API. #535
B2B-1237: [update] sync recent updates from B2B Edition API. #535
Conversation
741bb7c
to
ac4bdb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made comments to change to active voice. I tried to use the term "disabled" a little less. Some readers may consider the use of "disabled" as insensitive.
bd1f10d
to
892f1bc
Compare
@bc-traciporter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@JamessenLiu Would you like for me to merge this PR? |
Co-authored-by: Traci Porter <[email protected]>
…abled to turned off
55996a9
to
0a500ed
Compare
<!-- Ticket number or summary of work --> # [B2B-1354](https://bigcommercecloud.atlassian.net/browse/B2B-1354) ## What changed? <!-- Provide a bulleted list in the present tense --> ### Fix some issues Fix s2s endpoints issues in [google doc](https://docs.google.com/document/d/1maGQinFAxBQH8b3h0EGwzUZi9ikpf-mAgTWgVLqGo4I/edit?usp=sharing) * company a. Bulk Create Companies (request body has these additional read only fields (bcGroupName and companyStatus) **Create a new model for bulk company create (copy from orrigin), and remove 2 read only fields** * User a. Get a User (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** b. Get a User (meta is missing from the 404 error response) **Fix 404 response** c. Get a User (Should we document a 500 error response?) **Remove 500 response** d. Update a User (companyRoleId and companyRoleName are not in response body) **Add companyRoleName and companyRoleId in user response model** e. Delete a User (meta is missing from the 404 error response) **Fix 404 response** f. Delete a User (Should we document a 500 error response?) **Remove 500 response** g. Get Users (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** i. Bulk Create Company User (meta is missing from the 404 error response) **Fix 404 response** j. Get a User by Customer ID (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** k. Get a User by Customer ID (meta is missing from the 404 error response) **Fix 404 response** * Sales Staff a. Get a Sales Staff (assignedAt field is missing from the response body > assignedCompanies) **Add assignAt** * invoice payment a. Update a Offline Payment (422 error response is this correct? Data > currency) **Fix 422 response** ### Remove task section The task section has been removed in PR [535](#535), but re-created in PR [562](#562). May be conflicts between PR. As this section has already been removed in the original Stoplight, it should be removed again. ## Release notes draft <!-- Provide an entry for the release notes using simple, conversational language. Don't be too technical. Explain how the change will benefit the merchant and link to the feature. Examples: * The newly-released [X feature] is now available to use. Now, you’ll be able to [perform Y action]. * We're happy to announce [X feature], which can help you [perform Y action]. * [X feature] helps you to create [Y response] using the [Z query parameter]. Now, you can deliver [ex, localized shopping experiences for your customers]. * Fixed a bug in the [X endpoint]. Now the [Y field] will appear when you click [Z option]. --> n/a [B2B-1354]: https://bigcommercecloud.atlassian.net/browse/B2B-1354?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Traci Porter <[email protected]>
B2B-1327
What changed?
add tag for channel endpoints. Because the document did not display correctly when the tag was missing.
sync independent comapny docs from B2B stoplight
remove task section
add minModified query param for sales staff api
Release notes draft
N/A
Anything else?
ping {names}