Skip to content

Commit

Permalink
feat: STRF-12444 Suport Node 20, drop node 14, 16
Browse files Browse the repository at this point in the history
  • Loading branch information
jairo-bc committed Sep 24, 2024
1 parent f3b919f commit d076964
Show file tree
Hide file tree
Showing 6 changed files with 75 additions and 11 deletions.
28 changes: 28 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
Jira: [JIRA_TOKEN](https://bigcommercecloud.atlassian.net/browse/JIRA_TOKEN)

## What/Why?
<!---
A description about what this pull request implements and its purpose.
Try to be detailed and describe any technical details to simplify the job
of the reviewer and the individual on production support.
--->

## Rollout/Rollback
<!--
Detail how this change will be rolled out. Include reference to any
experiments and how the success will be measured as the experiment is
ramped.
Document rollback procedures. Is rolling back the change as simple as
rolling back an experiment or does it require reverting code? Are there
database migrations that may change our decision to roll forward instead of
back?
-->

## Testing
<!---
Provide as much information as you can about how you tested and how another
Engineer can test your change. Include screenshots, or test run output
where appropriate.
--->

7 changes: 3 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,21 @@ jobs:

strategy:
matrix:
node: [14.x]
node: [20.x]

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

- name: Set npm registry
run: echo "@bigcommerce-labs:registry=https://npm.pkg.github.com/" >> ~/.npmrc
- name: Set npm secrets
run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.DEPENDABOT_GITHUB_TOKEN }}" >> ~/.npmrc

- name: Install Dependencies
run: npm i
- name: Lint the code
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '14.x'
node-version: '20.x'
- name: Set npm registry
run: echo "@bigcommerce-labs:registry=https://npm.pkg.github.com/" >> ~/.npmrc
- name: Set npm secrets
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.20
20.16
41 changes: 39 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@
"webpack-cli": "^5.0.1"
},
"engines": {
"node": ">=14.0.0 <19.0.0"
"node": ">=18"
}
}

0 comments on commit d076964

Please sign in to comment.