[Q] @bigtreetech Faulty/buggy PR #2844 by Kisslorand, PLEASE DO NOT MERGE

[rondlh]

你好 @bigtreetech,

I want to bring to your attention that @kisslorand PR #2844 is faulty/buggy/non-functional and should NOT be merged.
I have been working with @kisslorand several times to try to help him to raise the quality of his PRs.
But Kisslorand doesn't like constructive criticism, he takes things personal, resulting in him blocking me.
So now I have no good way to inform him that #2844 is very bad. So I take this odd way to ask for your attention.

Kisslorand claims this at the introduction of the PR:

This PR was tested rigorously for a one week period for all the involved MCUs of this FW (even more, it was also tested on GD32F305VCT6 MCU too).

This is a complete non-sense The PR is completely non-functional and buggy, and doesn't fit in the current firmware strategy.
But still Kisslorand keeps force-pushing the PR starting from the day he published it.

In my view, PRs should be created based on an open discussion and they should be peer reviewed and tested, especially for PR that have hardware specific code. It would also be nice if the creator of the original code would have a chance to create a PR.

From @kisslorand I want to ask to stop making competing PRs based on other peoples' work without any discussion or cooperation. Please cancel #2844, if you want to help you can join #2840.

谢谢，
龙海业

[rondlh]

For reference, here an archive of #2844 (source code only), please don't download, this is non-functional buggy code!
Archive #2844 2023-09-27.zip

@kisslorand You claim that this software "was tested rigorously for a one week period for all the involved MCUs of this FW".
Which TFTs did you actually test this on?

UPDATE: It has been confirmed that @kisslorand didn't do any testing, he is again making false claims sabotaging this repository to benefit himself. The archive can be considered evidence of the buggy and untested code he is force pushing.

Additionally:
His PR #2833 was stolen from @digant73, it's almost an exact copy of the code, released 1 or 2 days after @digant73 released it.
His PR #2846 was stolen from me, I provided the code to him for testing and review, I never thought he would make a PR with it and try to claim he made it by changing a few variable names.

UPDATE 2: With the release of #2850 and #2851 @kisslorand has exposed himself as a liar willing to harm the community by providing misinformation. He used my development communication about #2840 to discredit the ADVANCED_OK update. What despicable behavior!

[rondlh]

By now it's clear that @kisslorand is spreading misinformation. In #2850 and #2851 he is lying about #2824, trying to get the PR reversed, which would be very painful and unneeded. #2824 is a great update providing ADVANCED_OK capabilities. @kisslorand's #2844 is buggy/faulty and completely non-functional, his code has not been tested, but still he is force-pushing the PR.
@kisslorand's behavior is very harmful and despicable. I don't know what drives him to act in this way. Perhaps his pride was hurt when I informed him about the flaws and incorrect claims in #2833.

In short:
#2850 is just a false claim trying to harm the community/ #2824 ADVANCED_OK support is a correct and valuable update.

#2851 is also wrong, but I can understand why he thinks this way, this might just be an honest mistake from @kisslorand's side

UPDATE 2:
#2850 has been closed. @kisslorand now claims that he just made a mistake, but from his malicious way of misquoting me and @digant73 his vicious intend is clear. Even the harm that he potentially could have inflicted on the users here did not stop him.

#2851 is currently still open, but @kisslorand now understands why he is wrong about this topic. His lack of communication skills becomes obvious. He could just have asking @digant73 why this issue occurred, to clarify the situation, but he rather raises a PR to discredit other users work without even understanding the what's going on.

[kisslorand]

Most certainly you have the right to your own opinion.

I will not lower myself to your level and call you names, anyone around here mature enough can see what's there to see.

As a side note, thank you very much for the free publicity, bringing the attention towards me will help more and more people to try the alternative FW from my repository and the result of the work I've done there would be the truth, not what random trolls are mumbling on the internet. The only thing people care about is to have finished prints done as perfectly as possible. The proof is in the pudding.

[rondlh]

@kisslorand Nobody cares about your buggy and slow repository, you must be out of your mind to even consider it. Your code is of very poor quality, because you do not communicate, coordinate, test or do peer reviews. Of course the outcome cannot be taken seriously. Your false performance claims have been debunked over and over again. Don't forget to re-enable the ban!

[kisslorand]

- Sparky! Who's the bad man?
- Wuff! Wuff!

Don't forget to re-enable the ban!

Hmmm. Actually I am enjoying the show. Can you show us again how you're chasing your tail?

As a side note, thank you very much for the free publicity, bringing the attention towards me will help more and more people to try the alternative FW from my repository and the result of the work I've done there would be the truth, not what random trolls are mumbling on the internet. The only thing people care about is to have finished prints done as perfectly as possible. The proof is in the pudding.

[rondlh]

Everyone: Be smart, don't install closed source firmware from other sites/repositories, it could be ransomware

[kisslorand]

Too late! What's done is done! It's ransom time baby! The evil plan was set in motion, let's burn some bridges!

Good boy, Sparky! Good boy! Now please do some roll-overs, let's see how entertaining you are...

As a side note, thank you very much for the free publicity, bringing the attention towards me will help more and more people to try the alternative FW from my repository and the result of the work I've done there would be the truth, not what random trolls are mumbling on the internet. The only thing people care about is to have finished prints done as perfectly as possible. The proof is in the pudding.

[rondlh]

Thanks @bigtreetech, the correct code (#2840) by @digant73 was merged, the buggy update (#2844) by kisslorand has become obsolete.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.