Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unnecessary fonts update due to PR #2824 #2851

Closed
kisslorand opened this issue Sep 29, 2023 · 1 comment · Fixed by #2873
Closed

[BUG] Unnecessary fonts update due to PR #2824 #2851

kisslorand opened this issue Sep 29, 2023 · 1 comment · Fixed by #2873
Labels
bug Something isn't working

Comments

@kisslorand
Copy link
Contributor

kisslorand commented Sep 29, 2023

Description

Updating to latest master the user is asked to update the fonts and icons also. This is a waste of time because no icons or fonts were changed/updated.

Steps to reproduce

  1. Update to latest master

Expected behavior
No fonts and icons update are requested

Actual behavior
Fonts and icons update are requested

Additional Information

This issue might be irrelevant given the severity of the issues the mentioned PR brings. Check it out here: #2850

Later edit: Looking up the code I understood why the update of the icons is necessary. It is because language size increased so the icons must go to a separate address in the flash memory leaving room for the increased space needed for the language.

@kisslorand kisslorand added the bug Something isn't working label Sep 29, 2023
@kisslorand kisslorand changed the title [BUG] Unnecessary fonts and icons update due to PR #2824 [BUG] Unnecessary fonts ~and icons~ update due to PR #2824 Sep 30, 2023
@kisslorand kisslorand changed the title [BUG] Unnecessary fonts ~and icons~ update due to PR #2824 [BUG] Unnecessary fonts update due to PR #2824 Sep 30, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant