Klipper 12864 improve #1913

Msq001 · 2021-05-13T06:30:20Z

Requirements

Klipper3d/klipper#3979 This PR of Klipper has solved the SPI data shift problem of TFT 12864 mode(Thanks @teeminus)
According to the setting in Klipper3d/klipper#3979 (comment), the TFT 12864 can work normally with Klipper

We need to set lcd_type to emulated_st7920, and set the correct pin of software_spi

[display]
lcd_type: emulated_st7920
spi_software_miso_pin: EXP2_1
spi_software_mosi_pin: EXP1_3
spi_software_sclk_pin: EXP1_5
en_pin: EXP1_4
encoder_pins: ^EXP2_3, ^EXP2_5
click_pin: ^!EXP1_2

Description

TFT work with SKR-2	Marlin & Full Screen OFF	Marlin & Full Screen ON	Klipper & Full Screen OFF	Klipper & Full Screen ON
TFT24 V1.1	💚good	⚠️beta	💚good	⚠️beta
TFT35 E3 V3.0	💚good	💚good	💚good	💚good
TFT50 V3.0	💚good	💚good	💚good	💚good
TFT70 V3.0	💚good	💚good	💚good	💚good

It reduces ram loss of hundreds of bytes and increases flash of tens of bytes

Benefits

Related Issues

fixed #290

oldman4U · 2021-05-13T09:43:05Z

Hi.

Should we ask the Klipper users to test this PR?

Msq001 · 2021-05-13T10:14:14Z

@oldman4U
This feature can be used normally, but the code needs more cleaning. After cleaning, I will convert to Ready for review, and then ask members to test

oldman4U · 2021-05-13T10:28:40Z

Perfect.

Thank you

TFT/src/User/API/boot.c

TFT/src/User/API/UI/ST7920_Emulator.c

TFT/src/User/API/UI/ST7920_Emulator.h

oldman4U · 2021-05-21T08:47:22Z

So the reaction of the community is overwhelming....

Have you got something back?

zyonee · 2021-05-21T16:43:21Z

This is working fine with an up to date version of Klipper on an SKR E3 Turbo with a BTT TFT70.

Talha909 · 2021-06-03T12:49:05Z

My lcd show the result on screen. But rotary switch did not work. What should i do

jasc76 · 2021-06-03T16:46:17Z

Tested this on TFT24 with MKS GEN L with the provided [display] section above.

Klippy Error:
Unknown value 'EXP2_1' in enumeration 'pin'
This type of error is frequently caused by running an older
version of the firmware on the micro-controller (fix by
recompiling and flashing the firmware).

Known versions: host=v0.9.1-533-g27f8cf02, mcu=v0.9.1-528-gc0d86048

printer.cfg
aliases:
# EXP1 header
EXP1_1=ar37, EXP1_3=ar17, EXP1_5=ar23, EXP1_7=ar27, EXP1_9=,
EXP1_2=ar35, EXP1_4=ar16, EXP1_6=ar25, EXP1_8=ar29, EXP1_10=<5V>

# EXP2 header
EXP2_1=ar50, EXP2_3=ar31, EXP2_5=ar33, EXP2_7=ar49, EXP2_9=<GND>,
EXP2_2=ar52, EXP2_4=ar53, EXP2_6=ar51,  EXP2_8=<RST>, EXP2_10=ar41

[display]
lcd_type: emulated_st7920
spi_software_miso_pin: EXP2_1
spi_software_mosi_pin: EXP1_3
spi_software_sclk_pin: EXP1_5
en_pin: EXP1_4
encoder_pins: ^EXP2_5, ^EXP2_3
click_pin: ^!EXP1_2
[output_pin beeper]
pin: EXP1_1

bigtreetech · 2021-06-05T01:19:40Z

My lcd show the result on screen. But rotary switch did not work. What should i do

Which motherboard do you use? Maybe there is something wrong with the setting of

encoder_pins: ^EXP2_3, ^EXP2_5
click_pin: ^!EXP1_2

bigtreetech · 2021-06-05T01:34:44Z

Klippy Error:
Unknown value 'EXP2_1' in enumeration 'pin'
This type of error is frequently caused by running an older
version of the firmware on the micro-controller (fix by
recompiling and flashing the firmware).

Known versions: host=v0.9.1-533-g27f8cf02, mcu=v0.9.1-528-gc0d86048

Do you using the latest version of klipper and the MCU of MKS GEN L has also updated the latest version of firmware.bin?

jasc76 · 2021-06-05T03:49:45Z

Known versions: host=v0.9.1-533-g27f8cf02, mcu=v0.9.1-533-g27f8cf02, rpi=v0.9.1-533-g27f8cf02

no change, error still is there. Its the latest kiauh is offering

What I discovered:
Changing
spi_software_miso_pin: EXP2_1
to
spi_software_miso_pin: EXP2_2 (was just an idea, what happens)
the error goes away and it works (screen, encoder, click, beeper tested)

Talha909 · 2021-06-08T06:19:25Z

I am using skr 1.4 Tubo. I got the display on the screen but my rotary switch did not work and there is no beeper. What should i do

bigtreetech · 2021-06-08T08:43:07Z

I am using skr 1.4 Tubo. I got the display on the screen but my rotary switch did not work and there is no beeper. What should i do

Hello, Can you confirm that the following pins are set properly? If you are still unable to work after confirmation, please provide your printer.cfg file

encoder_pins: ^EXP2_3, ^EXP2_5
click_pin: ^!EXP1_2

[output_pin beeper]
pin: EXP1_1

Talha909 · 2021-06-09T04:53:58Z

HI, Still facing the issue. My rotary switch is not working. I am using SKR 1.4 Tubo, TMC2130 and TFT 24
printer (5).zip

gregmatic · 2021-06-20T07:59:12Z

my screen shows Marlin Mode with blank screen. can anyone confirm the following works with SKR E3 Mini v1.2 & TFT35 E3 V3.0?

[board_pins]
aliases:
# EXP1 header
EXP1_1=PB5, EXP1_3=PA9, EXP1_5=PA10, EXP1_7=PB8, EXP1_9=,
EXP1_2=PB6, EXP1_4=, EXP1_6=PB9, EXP1_8=PB7, EXP1_10=<5V>

[display]
lcd_type: emulated_st7920
spi_software_miso_pin: EXP2_1
spi_software_mosi_pin: EXP1_3
spi_software_sclk_pin: EXP1_5
en_pin: EXP1_4
encoder_pins: ^EXP2_3, ^EXP2_5
click_pin: ^!EXP1_2

bigtreetech · 2021-06-22T10:38:05Z

my screen shows Marlin Mode with blank screen. can anyone confirm the following works with SKR E3 Mini v1.2 & TFT35 E3 V3.0?

[board_pins]
aliases:

EXP1 header

EXP1_1=PB5, EXP1_3=PA9, EXP1_5=PA10, EXP1_7=PB8, EXP1_9=,
EXP1_2=PB6, EXP1_4=, EXP1_6=PB9, EXP1_8=PB7, EXP1_10=<5V>

[display]
lcd_type: emulated_st7920
spi_software_miso_pin: EXP2_1
spi_software_mosi_pin: EXP1_3
spi_software_sclk_pin: EXP1_5
en_pin: EXP1_4
encoder_pins: ^EXP2_3, ^EXP2_5
click_pin: ^!EXP1_2

According to the instructions here
https://github.com/KevinOConnor/klipper/blob/478f26cab6c8e73e3970d2b303bc818f6910ae74/config/sample-lcd.cfg#L49
SKR-mini-E3-V1.2 has no EXP1 + EXP2 and only the Ender-3 stock display port, so the settings should be as follows

[display]
lcd_type: st7920
cs_pin: EXP1_7
sclk_pin: EXP1_6
sid_pin: EXP1_8
encoder_pins: ^EXP1_5, ^EXP1_3
click_pin: ^!EXP1_2

[output_pin beeper]
pin: EXP1_1

gregmatic · 2021-06-23T14:10:15Z

[display]
lcd_type: st7920
cs_pin: EXP1_7
sclk_pin: EXP1_6
sid_pin: EXP1_8
encoder_pins: ^EXP1_5, ^EXP1_3
click_pin: ^!EXP1_2

[output_pin beeper]
pin: EXP1_1

thank you...i tried this but Marlin Mode still shows black screen. I didn't move any wiring ...the TFT35 worked fine in both Marlin Mode & Touch Mode when my firmware was Marlin..

when i plug in to stock Ender 3 LCD, it works. so i'm not sure what's wrong with my TFT35 that makes it not want to talk to Klipper. I used the compiled binary from master fork.

edit: i'm quite sure its this official firmware that doesn't work. i flashed NoTouchv1.3 from here and it worked...i have no idea why.

Terixxx · 2021-07-29T11:02:08Z

Requirements

KevinOConnor/klipper#3979 This PR of Klipper has solved the SPI data shift problem of TFT 12864 mode(Thanks @teeminus)
According to the setting in KevinOConnor/klipper#3979 (comment), the TFT 12864 can work normally with Klipper

We need to set lcd_type to emulated_st7920, and set the correct pin of software_spi
[display]
lcd_type: emulated_st7920
spi_software_miso_pin: EXP2_1
spi_software_mosi_pin: EXP1_3
spi_software_sclk_pin: EXP1_5
en_pin: EXP1_4
encoder_pins: ^EXP2_3, ^EXP2_5
click_pin: ^!EXP1_2
Description

TFT work with SKR-2 Marlin & Full Screen OFF Marlin & Full Screen ON Klipper & Full Screen OFF Klipper & Full Screen ON
TFT24 V1.1 💚good ⚠️beta 💚good ⚠️beta
TFT35 E3 V3.0 💚good 💚good 💚good 💚good
TFT50 V3.0 💚good 💚good 💚good 💚good
TFT70 V3.0 💚good 💚good 💚good 💚good

It reduces ram loss of hundreds of bytes and increases flash of tens of bytes

Benefits

Related Issues

fixed #290

Could you please provide Pin map and board corresponding to this configuration. I have BTT Octopus V1.1 and TFT3.5 V3.0 and have issue with TMC2130 SPI drivers.

hapklaar · 2021-08-12T13:46:03Z

@Msq001 This is working for me, except for that the screen gets garbled/scrambled after a few minutes of printing. Tried both ways of addressing the screen, doesn't seem to matter for this specific problem.

[display]
lcd_type: st7920 
cs_pin: EXP1_4
sclk_pin: EXP1_5
sid_pin: EXP1_3
encoder_pins: ^EXP2_5, ^EXP2_3
click_pin: ^!EXP1_2

and

[display]
lcd_type: emulated_st7920
spi_software_miso_pin: EXP2_1
spi_software_mosi_pin: EXP1_3
spi_software_sclk_pin: EXP1_5
en_pin: EXP1_4
encoder_pins: ^EXP2_3, ^EXP2_5
click_pin: ^!EXP1_2

vMeph · 2022-01-24T00:37:49Z

@Msq001 could you provide the config for the btt SKR2 to testout
thanks in advanced

vMeph · 2022-01-25T19:43:08Z

its working !!!

mlaci001 · 2022-02-10T08:02:42Z

The same is true with the E3 turbo and TFT35-E3-v3.
The screen is blank.
If the TFT button is held down for 3 seconds, the mode selection window will appear, here you have to select the Marlin mode (no matter what mode the screen is in).
The screen will still be blank, but if you press the button again, the menu will appear and work from there.
You have to do it again every time you start.
I don't know why it's not good at startup.
I can't use emulated_st7920 mode, the motherboard only has an EXP1 connector.

chaicracker · 2022-03-30T16:21:25Z

Hello everyone :)

Currently trying to get a BTT TFT35 V3 (the wide one, not the E3 version) working with an SKR Mini E3 V2.0

this is the configuration I could muster so far, though none of the tries suceeded so far. I had installed the fitting NoTouchScreenFirmware for the Display and says "ST7920Emulated ready"

[board_pins]
aliases:
EXP1_1=PB5, EXP1_3=PA9, EXP1_5=PA10, EXP1_7=PB8, EXP1_9=,
EXP1_2=PA15, EXP1_4=, EXP1_6=PB9, EXP1_8=PB15, EXP1_10=<5V>,

[display]
lcd_type: emulated_st7920
en_pin: EXP1_7
spi_software_sclk_pin: EXP1_6
spi_software_mosi_pin: EXP1_8
spi_software_miso_pin: PA3
encoder_pins: ^EXP1_5, ^EXP1_3
click_pin: ^!EXP1_2

Cheers :)

douglasdtlltd · 2022-10-07T08:03:42Z

This works with a current compile of the BTT TF35 V3.0 firmware and a BTT SKR Mini E3 V2 with Klipper.

IM SO HAPPY I FOUND THIS.

Hello everyone :)

Currently trying to get a BTT TFT35 V3 (the wide one, not the E3 version) working with an SKR Mini E3 V2.0

this is the configuration I could muster so far, though none of the tries suceeded so far. I had installed the fitting NoTouchScreenFirmware for the Display and says "ST7920Emulated ready"

[board_pins] aliases: EXP1_1=PB5, EXP1_3=PA9, EXP1_5=PA10, EXP1_7=PB8, EXP1_9=, EXP1_2=PA15, EXP1_4=, EXP1_6=PB9, EXP1_8=PB15, EXP1_10=<5V>,

[display] lcd_type: emulated_st7920 en_pin: EXP1_7 spi_software_sclk_pin: EXP1_6 spi_software_mosi_pin: EXP1_8 spi_software_miso_pin: PA3 encoder_pins: ^EXP1_5, ^EXP1_3 click_pin: ^!EXP1_2

Cheers :)

The only problem I have no is that I can't edit the displays settings in the touch mode because it "doesnt have a printer connected." obviously. ugh.

another edit that was quick google if you found this comment, I found this.

https://www.reddit.com/r/BIGTREETECH/comments/ieoua5/tft24_display_rotation/g2jcjx8/

bigtreetech/BIGTREETECH-TouchScreenFirmware#1913 (comment) This config allows the use of BTT TFT displays with the latest compiled version of BTT firmware (Only tested working on TFT35 V3.0) This information was a pain to find and would like to make it easier for other users of this display.

Msq001 marked this pull request as draft May 13, 2021 10:12

guruathwal reviewed May 14, 2021

View reviewed changes

TFT/src/User/API/boot.c Outdated Show resolved Hide resolved

digant73 reviewed May 15, 2021

View reviewed changes

TFT/src/User/API/UI/ST7920_Emulator.c Outdated Show resolved Hide resolved

Msq001 and others added 2 commits May 18, 2021 10:13

klipper 12864

69fcf0a

clean up

8ed8d14

bigtreetech marked this pull request as ready for review May 18, 2021 08:19

bigtreetech added 2 commits May 18, 2021 16:31

add 8x16 ascii font

d256419

Update platformio.ini

e7df7be

digant73 suggested changes May 18, 2021

View reviewed changes

TFT/src/User/API/UI/ST7920_Emulator.h Outdated Show resolved Hide resolved

Update ST7920_Emulator.h

455f483

This was referenced May 19, 2021

[FR] Feature Request List #1170

Closed

[FR] [ST7920_Simulator.c] Add a character generator in order to use klipper #290

Closed

bigtreetech merged commit b8b5cd2 into bigtreetech:master May 22, 2021

Msq001 deleted the klipper branch May 22, 2021 10:03

hapklaar mentioned this pull request Aug 12, 2021

Screen will always get garbled after a while. teeminus/NoTouchScreenFirmware#47

Open

mpalpha mentioned this pull request Oct 28, 2021

MKS Robin TFT35 v1.0 LCD support for klipper makerbase-mks/Klipper-for-MKS-Boards#12

Closed

jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021

Klipper 12864 improve (bigtreetech#1913)

9ee8829

douglasdtlltd mentioned this pull request Oct 7, 2022

Update Sample LCD config with support for BTT TFT Klipper3d/klipper#5815

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Klipper 12864 improve #1913

Klipper 12864 improve #1913

Msq001 commented May 13, 2021 •

edited by bigtreetech

Loading

oldman4U commented May 13, 2021

Msq001 commented May 13, 2021 •

edited

Loading

oldman4U commented May 13, 2021

oldman4U commented May 21, 2021

zyonee commented May 21, 2021

Talha909 commented Jun 3, 2021

jasc76 commented Jun 3, 2021

bigtreetech commented Jun 5, 2021

bigtreetech commented Jun 5, 2021

jasc76 commented Jun 5, 2021 •

edited

Loading

Talha909 commented Jun 8, 2021

bigtreetech commented Jun 8, 2021

Talha909 commented Jun 9, 2021

gregmatic commented Jun 20, 2021

bigtreetech commented Jun 22, 2021

EXP1 header

gregmatic commented Jun 23, 2021 •

edited

Loading

Terixxx commented Jul 29, 2021 •

edited

Loading

Requirements

Description

Benefits

Related Issues

hapklaar commented Aug 12, 2021

vMeph commented Jan 24, 2022

vMeph commented Jan 25, 2022

mlaci001 commented Feb 10, 2022

chaicracker commented Mar 30, 2022 •

edited

Loading

douglasdtlltd commented Oct 7, 2022 •

edited

Loading

Klipper 12864 improve #1913

Klipper 12864 improve #1913

Conversation

Msq001 commented May 13, 2021 • edited by bigtreetech Loading

Requirements

Description

Benefits

Related Issues

oldman4U commented May 13, 2021

Msq001 commented May 13, 2021 • edited Loading

oldman4U commented May 13, 2021

oldman4U commented May 21, 2021

zyonee commented May 21, 2021

Talha909 commented Jun 3, 2021

jasc76 commented Jun 3, 2021

bigtreetech commented Jun 5, 2021

bigtreetech commented Jun 5, 2021

jasc76 commented Jun 5, 2021 • edited Loading

Talha909 commented Jun 8, 2021

bigtreetech commented Jun 8, 2021

Talha909 commented Jun 9, 2021

gregmatic commented Jun 20, 2021

bigtreetech commented Jun 22, 2021

EXP1 header

gregmatic commented Jun 23, 2021 • edited Loading

Terixxx commented Jul 29, 2021 • edited Loading

Requirements

Description

Benefits

Related Issues

hapklaar commented Aug 12, 2021

vMeph commented Jan 24, 2022

vMeph commented Jan 25, 2022

mlaci001 commented Feb 10, 2022

chaicracker commented Mar 30, 2022 • edited Loading

douglasdtlltd commented Oct 7, 2022 • edited Loading

Msq001 commented May 13, 2021 •

edited by bigtreetech

Loading

Msq001 commented May 13, 2021 •

edited

Loading

jasc76 commented Jun 5, 2021 •

edited

Loading

gregmatic commented Jun 23, 2021 •

edited

Loading

Terixxx commented Jul 29, 2021 •

edited

Loading

chaicracker commented Mar 30, 2022 •

edited

Loading

douglasdtlltd commented Oct 7, 2022 •

edited

Loading