Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoided possible freezes looping on loopProcess function #1959

Merged
merged 4 commits into from
Jun 2, 2021
Merged

avoided possible freezes looping on loopProcess function #1959

merged 4 commits into from
Jun 2, 2021

Conversation

digant73
Copy link
Contributor

@digant73 digant73 commented May 31, 2021 •
edited
Loading

BUG FIXES:

  • looping on loopProcess function will create a freeze condition in case a user interaction is requested (e.g. dialog, popup etc... are displayed). The user interaction is not allowed (it's no more possible to click on any button). This PR makes possible the user interaction needed to complete the related task and thus also allowing to create the condition to leave the loop on loopProcess function

NOTES:

PR STATE: ready to merge

@digant73 digant73 mentioned this pull request May 31, 2021
Closed
@bigtreetech bigtreetech merged commit e9562a0 into bigtreetech:master Jun 2, 2021
This was referenced Jun 2, 2021
Closed
Closed
@radek8 radek8 mentioned this pull request Jun 9, 2021
Closed
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
@digant73
avoided possible freezes looping on loopProcess function (bigtreetech…
945caa0 
…#1959)
@kisslorand kisslorand mentioned this pull request Aug 28, 2022
Closed
@kisslorand kisslorand mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusThur MarkusThur MarkusThur left review comments

@guruathwal guruathwal guruathwal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@digant73 @guruathwal @MarkusThur @bigtreetech