Leveling edge distance count from zero position #2266
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, during manual bed leveling the edge bed coordinates are counted from the minimum value if >=0 (Home position). Unfortunately, when we have coordinates other than 0 at the Home position (e.g. size_min:X-10 Y-5), the physical edge positioning will is faulty. With level edge distance value at 20, the lower left corner will be at real position X10 Y15, not X20 Y20 (liked in Marlin). The last fix did not completely delete the problem.
Positioning with manual leveling is an internal affair of TFT Firmware and should not be fixed otherwise as here.
Benefits
This solution calculates the correct bed edge coordinates for manual leveling regardless of:
M115_GEOMETRY_REPORT
Marlin option,The level_edge_distance will be counted from true 0 position (liked in Marlin). For example, if you have
size_min: X-5 Y-18
andlevel_edge_distance: 30
, the lower left leveling point would be at real X30 Y30 (liked in Marlin). This applies to all corners and center point too (if you have the correctsize_max
).Note: When you have enabled
M115_GEOMETRY_REPORT
option in Marlin, then don't need to setsize_min
andsize_max
. However, if you don't haveM115_GEOMETRY_REPORT
option in Marlin, then you then you have to enter values forsize_min
andsize_max
in file(s):config.ini
and/orConfiguration.h
.Related Issues
#1151